Skip to content

Enhancing the use of external nowcasts to also support ensembles and noise #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Enhancing the use of external nowcasts to also support ensembles and noise #520

wants to merge 21 commits into from

Conversation

@Joep1999
Copy link
Contributor

@Joep1999 Joep1999 commented Sep 11, 2025

No description provided.

@RubenImhoff RubenImhoff self-requested a review September 12, 2025 07:56
@RubenImhoff
Copy link
Contributor

RubenImhoff commented Sep 12, 2025

Still in progress, but fixes #482.

@RubenImhoff RubenImhoff added the enhancement New feature or request label Sep 12, 2025
@RubenImhoff RubenImhoff linked an issue Sep 12, 2025 that may be closed by this pull request
STEPS blending procedure with other nowcasting models #482
Open
4 tasks
@codecov
Copy link

codecov bot commented Sep 23, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 34.04255% with 93 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.81%. Comparing base (b12c420) to head (3b256e9).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pysteps/blending/steps.py 32.60% 93 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
- Coverage   84.14%   83.81%   -0.34%     
==========================================
  Files         168      168              
  Lines       14507    14588      +81     
==========================================
+ Hits        12207    12227      +20     
- Misses       2300     2361      +61
Flag Coverage Δ
unit_tests 83.81% <34.04%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RubenImhoff
Copy link
Contributor

RubenImhoff commented Sep 26, 2025 •
edited
Loading

Tasks:

  • Add noise generator to external nowcast setup.
  • Add option to provide ensemble nowcast.
  • Add option to provide deterministic nowcast, but request ensemble output.
  • Add gallery example.
  • Add and update tests.

@RubenImhoff
Copy link
Contributor

RubenImhoff commented Nov 4, 2025

Hi @Joep1999, nice work! Sorry it took me a little longer than I'd hoped for to review your last changes. It looks good! I see that the code coverage with tests is still giving a warning, so we may have to check if there a few code lines that need tests. In the meantime, just to check, @dnerini or maybe @sidekock, would you like to have a look at this PR as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RubenImhoff RubenImhoff RubenImhoff approved these changes

Assignees

@RubenImhoff RubenImhoff

@Joep1999 Joep1999

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

STEPS blending procedure with other nowcasting models

2 participants

@Joep1999 @RubenImhoff